FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

'fix the warnings from 'is not 0' to '!= 0' in management.py by bpmcdevitt · Pull Request #82 · osquery/osquery-python · GitHub

/ osquery-python Public

'fix the warnings from 'is not 0' to '!= 0' in management.py - #82

Merged
zwass merged 1 commit into
osquery:masterfrom
bpmcdevitt:master
Apr 12, 2022
ConversationCommits (1)ChecksFiles changed
Merged

'fix the warnings from 'is not 0' to '!= 0' in management.py#82
zwass merged 1 commit into
osquery:masterfrom
bpmcdevitt:master

Conversation

bpmcdevitt commented Apr 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I am working on a project where I am using this python library in a Windows and Linux environment. It is super convenient for getting python to communicate with osqueryd.

I am using this module with Python version 3.9 in my environment and I am receiving the following warnings referencing the management.py file:

In [1]: from osquery_interface import OsqueryInterface
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:186: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if status.code is not 0:
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:243: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if status.code is not 0:
c:\users\booboy\.virtualenvs\query_app_inf_osquery-dn8tsr2s\src\osquery\osquery\management.py:295: SyntaxWarning: "is not" with a literal. Did you mean "!="?

This PR will fix those warnings and replace the is not 0 with != 0 in the management.py file.

linux-foundation-easycla Bot commented Apr 24, 2021 •
edited
Loading

Copy link
Copy Markdown



The committers are authorized under a signed CLA.

zwass approved these changes Apr 12, 2022
View reviewed changes

zwass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your contribution! Sorry that osquery-python has not seen a lot of love recently.

I'm looking to release a new version soon.

zwass merged commit 451045e into osquery:master Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zwass zwass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL