Fix handling of exceptions when osquery goes away - #83
Merged
zwass merged 2 commits intoApr 15, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This resolves an issue where the extension does not shut down if osquery goes away unexpectedly (without sending a shutdown signal via Thrift). The scenario could be reliably reproduced by running `osqueryi`, connecting an extension, and then sending a `SIGKILL` to `osqueryi`. The exception thrown in the `start_watcher` function would be of type `thrift.transport.TTransport.TTransportException`, and would cause the watcher thread to exit without exiting the rest of the program. This is a possible fix for issues that users have experienced with extensions reconnecting after the Watchdog kills osquery.
2 tasks
sharvilshah
requested changes
Apr 12, 2022
sharvilshah
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think we will need to update the version in https://github.com/osquery/osquery-python/blob/master/osquery/__init__.py#L7 too?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'd prefer to keep those version updates in a separate PR (#84). @sharvilshah does that work for you? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
That works! |
Sorry, something went wrong.
sharvilshah
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the extension does not shut down if osquery
goes away unexpectedly (without sending a shutdown signal via Thrift).
The scenario could be reliably reproduced by running osqueryi,
connecting an extension, and then sending a SIGKILL to osqueryi. The
exception thrown in the start_watcher function would be of type
thrift.transport.TTransport.TTransportException, and would cause the
watcher thread to exit without exiting the rest of the program.
This is a possible fix for issues that users have experienced with
extensions reconnecting after the Watchdog kills osquery.