fix: chown /var/lib/overleaf mount point to www-data - #1475
Conversation
Sorry, something went wrong.
The init script chowns all subdirectories but not the mount point itself. When the host volume is owned by a non-www-data user with restrictive permissions (e.g. 770), the web process cannot traverse the directory and crashes with EACCES, causing a 502. Fixes overleaf#1325 and overleaf#1465
|
@das7pad thoughts on this? I understand we've intentionally tried to avoid changing the ownership of the mount point, but I see the situation with 770 permissions. Maybe chmod a+x /var/lib/overleaf is enough here? |
Sorry, something went wrong.
das7pad
left a comment
There was a problem hiding this comment.
Looks sensible to me.
Sorry, something went wrong.
|
Hey @ev-not-eve I haven't been able to find the record of your signature in the Contributor License Agreement. Did you indicate a different Github handle perhaps? |
Sorry, something went wrong.
redid my signature; made sure to include my github handle. It’s possible that I misspelled it the first time :) |
Sorry, something went wrong.
|
Hey @ev-not-eve I have some issues importing this PR into our internal repos using our internal syncing process (likely caused by our yarn migration). Do you mind rebasing the PR against the main branch? Sorry for the hassle! Nevermind, I managed to sort out the issue. |
Sorry, something went wrong.
The init script chowns all subdirectories but not the mount point itself. When the host volume is owned by a non-www-data user with restrictive permissions (e.g. 770), the web process cannot traverse the directory and crashes with EACCES, causing a 502. Fixes #1325 and #1465 COPYBARA_INTEGRATE_REVIEW=#1475 from ev-not-eve:patch-1 269a805 Co-authored-by: Evelyn <evansvevelyn@gmail.com> GitOrigin-RevId: 959051861246c9f3958e56861821b92d84167926
Description
The init script chowns all subdirectories but not the mount point itself. When the host volume is owned by a non-www-data user with restrictive permissions (e.g. 770), the web process cannot traverse the directory and crashes with EACCES, causing a 502.
Related issues / Pull Requests
Fixes #1325 and #1465
Contributor Agreement