refactor(xtask): use globals from node_modules instead of HTTP - #144
Merged
Boshen merged 3 commits intoJan 14, 2026
Merged
Boshen merged 3 commits into
Boshen merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace HTTP fetch from GitHub with reading globals.json from node_modules. This removes the ureq dependency and its transitive dependencies, significantly reducing Cargo.lock size. - Replace ureq with serde_json for JSON parsing - Read from node_modules/globals/globals.json - Add setup-node step to CI workflows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reduces Cargo.lock by ~730 lines by removing ureq and its transitive dependencies.
Test plan
🤖 Generated with Claude Code