FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: export individual env statics by Boshen · Pull Request #189 · oxc-project/javascript-globals · GitHub

feat: export individual env statics - #189

Merged
Boshen merged 1 commit into
mainfrom
export-individual-env-statics
Mar 24, 2026
Merged

Boshen merged 1 commit into
mainfrom
export-individual-env-statics

Conversation

Boshen commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Export each environment as its own pub static GLOBALS_<NAME> (e.g. GLOBALS_BUILTIN, GLOBALS_ES2025, GLOBALS_BROWSER), allowing direct access without PHF lookups
  • Wrap the main GLOBALS in a Globals struct that holds references (&'static phf::Map) to the individual statics
  • GLOBALS["builtin"]["Date"] continues to work via Index impl

Closes #149

🤖 Generated with Claude Code

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7d08e2fc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib.rs Outdated
Boshen force-pushed the export-individual-env-statics branch 2 times, most recently from b2872f9 to bb0865b Compare March 24, 2026 14:27
Export each environment as its own `pub static GLOBALS_<NAME>`, allowing
direct access (e.g. `GLOBALS_BUILTIN`) without PHF lookups.

The main `GLOBALS` static is now a `Globals` wrapper struct that holds
references to the individual statics.

Closes #149

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb0865bdb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib.rs
Boshen force-pushed the export-individual-env-statics branch from bb0865b to b46c915 Compare March 24, 2026 14:30
Boshen merged commit c43e1d0 into main Mar 24, 2026
2 checks passed
Boshen deleted the export-individual-env-statics branch March 24, 2026 14:37
Boshen mentioned this pull request Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export individual envs as separate statics

1 participant


Back | FazBrowse Home | New Git URL