Repository navigation
Add PolygonSeries - #2033
Draft
VisualMelon wants to merge 7 commits into
Draft
Add PolygonSeries#2033VisualMelon wants to merge 7 commits into
VisualMelon wants to merge 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
VisualMelon
commented
Aug 16, 2023
Comment thread
Source/OxyPlot/Series/PolygonItem.cs
Comment on lines
+94
to
+120
| // DataPoint cur = outline[0]; | ||
| // DataPoint prev; | ||
| // for (int i = 1; i < outline.Length; i++) | ||
| // { | ||
| // prev = cur; | ||
| // cur = outline[i]; | ||
|
|
||
| // if (cur.Equals(prev)) | ||
| // { | ||
| // continue; | ||
| // } | ||
|
|
||
| // var y0 = Math.Min(cur.Y, prev.Y); | ||
| // var y1 = Math.Max(cur.Y, prev.Y); | ||
|
|
||
| // if (y0 > p.Y || y1 <= p.Y) | ||
| // continue; | ||
|
|
||
| // var c = (p.Y - prev.Y) / (cur.Y - prev.Y); | ||
| // var x = prev.Y + c * (cur.X - prev.Y); | ||
|
|
||
| // if (x <= p.X) | ||
| // intersectionCount++; | ||
| // } | ||
|
|
||
| // return intersectionCount % 2 == 0; | ||
| //} |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
No idea where this code came from or if it works for why it's commented out. Probably don't need it at all (tracker is done in screen space).
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Outstanding questions:
Outstanding problems:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Our rendering API does not really support this I think... So this may be hard to implement even if we found a good way to represent this. So I would think we could do without for now.
An outline tracker (that could be enabled as an option) could be nice-to-have, but I wouldn't consider it a must from the start. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Here are my impressions after trying it out.
System.NullReferenceException HResult=0x80004003 Message=Object reference not set to an instance of an object. Source=OxyPlot スタック トレース: 場所 OxyPlot.Axes.ColorAxisExtensions.GetColor(IColorAxis axis, Double value) (.\oxyplot-polygonseries\Source\OxyPlot\Axes\ColorAxisExtensions.cs):行 25
System.FormatException HResult=0x80131537 Message=インデックス (0 ベース) は 0 以上で、引数リストのサイズよりも小さくなければなりません。 Source=mscorlib スタック トレース: 場所 System.Text.StringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args) 場所 System.String.FormatHelper(IFormatProvider provider, String format, ParamsArray args) 場所 System.String.Format(String format, Object[] args) 場所 OxyPlot.CodeGenerator.FormatCode(String format, Object[] values) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 110 場所 OxyPlot.CodeGenerator.FormatConstructor(Type type, String format, Object[] values) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 122 場所 OxyPlot.Series.PolygonItem.ToCode() (.\oxyplot-polygonseries\Source\OxyPlot\Series\PolygonItem.cs):行 130 場所 OxyPlot.CodeGeneratorStringExtensions.ToCode(Object value) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGeneratorStringExtensions.cs):行 156 場所 OxyPlot.CodeGenerator.AddItems(String name, IList list) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 182 場所 OxyPlot.CodeGenerator.SetProperties(Object instance, String varName, Object defaultValues) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 406 場所 OxyPlot.CodeGenerator.Add(Object obj) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 154 場所 OxyPlot.CodeGenerator.AddChildren(String name, String collectionName, IEnumerable children) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 168 場所 OxyPlot.CodeGenerator..ctor(PlotModel model) (.\oxyplot-polygonseries\Source\OxyPlot\Foundation\CodeGenerator\CodeGenerator.cs):行 71 場所 OxyPlot.PlotModel.ToCode() (.\oxyplot-polygonseries\Source\OxyPlot\PlotModel\PlotModel.cs):行 722 場所 ExampleLibrary.ExampleInfo.GetCode(ExampleFlags flags) (.\oxyplot-polygonseries\Source\Examples\ExampleLibrary\ExampleInfo.cs):行 112 場所 ExampleBrowser.MainWindowViewModel.UpdatePlotModel() (.\oxyplot-polygonseries\Source\Examples\WPF\ExampleBrowser\MainWindowViewModel.cs):行 161 場所 ExampleBrowser.MainWindowViewModel.CoerceSelectedExample() (.\oxyplot-polygonseries\Source\Examples\WPF\ExampleBrowser\MainWindowViewModel.cs):行 151 場所 ExampleBrowser.MainWindowViewModel.set_SelectedExample(ExampleInfo value) (.\oxyplot-polygonseries\Source\Examples\WPF\ExampleBrowser\MainWindowViewModel.cs):行 111 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the feedback: working without a color axis is clearly an overlooked use case. |
Sorry, something went wrong.
Fixed an issue where PolygonSeries was not displayed correctly in ExampleBrowser. Fixes for errors from the IDE
Fix `PolygonItem.ToCode`
Add SADASHIMA as a contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1751 .
Checklist
-> want some interesting/compelling examples
Changes proposed in this pull request:
@oxyplot/admins