Modify requests ReadTimeout - #53
Merged
b4oshany merged 1 commit intoAug 10, 2018
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
… attribute is passed in, otherwise default to decorators value
Copy link
Copy Markdown
|
+1, was just considering writing this same pull request. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
+1 for the fix |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to customize requests ReadTimeout if session with timeout attribute is passed in, otherwise default to decorators value.
Allows you to pass in your own requests.Session() object with a timeout field. This allows people to have a customized ReadTimeout that is much shorter than the default 60 seconds. Useful when Firebase is having intermittent server issues, so retrys can happen at a quicker rate.