Bump down required python version - #38
Merged
gatesn merged 1 commit intoApr 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for your interest in palantir/python-language-server, @MathieuDuponchelle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
For the record, I only signed the CLA because I like the name of the company :P |
Sorry, something went wrong.
gatesn
approved these changes
Apr 6, 2017
gatesn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
steff456
pushed a commit
to steff456/spyder-pyls
that referenced
this pull request
Aug 3, 2020
Install and use future only if python2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2, the test suite passes for me with python 3.4.3, so might as well not make it seem a more recent version is required :)