FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

area/ui: auto close the group by dropdown when there's an outside click by yomete · Pull Request #5381 · parca-dev/parca · GitHub

area/ui: auto close the group by dropdown when there's an outside click - #5381

Merged
yomete merged 1 commit into
mainfrom
auto-dismiss-groupby
Dec 11, 2024
Merged

area/ui: auto close the group by dropdown when there's an outside click#5381
yomete merged 1 commit into
mainfrom
auto-dismiss-groupby

Conversation

yomete commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Fixes #5378

yomete requested a review from a team as a code owner December 11, 2024 13:29

alwaysmeticulous Bot commented Dec 11, 2024
edited
Loading

Copy link
Copy Markdown

🤖 Meticulous spotted visual differences in 4 of 223 screens tested: view and approve differences detected.

Meticulous simulated ~5 hours of user flows against your PR.

Last updated for commit 68d4a3e. This comment will update as new commits are pushed.

manojVivek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm!

yomete merged commit c8b98c9 into main Dec 11, 2024
yomete deleted the auto-dismiss-groupby branch December 11, 2024 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group-by menu doesn't close as expected

2 participants


Back | FazBrowse Home | New Git URL