area/ui: add a new queryparam selectedSeries to query for cpu strips and flamechart - #5544
Merged
metalmatze merged 2 commits intoFeb 26, 2025
Merged
area/ui: add a new queryparam selectedSeries to query for cpu strips and flamechart#5544metalmatze merged 2 commits into
metalmatze merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
✅ Meticulous spotted zero visual differences across 193 screens tested: view results. Meticulous simulated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 1795304. This comment will update as new commits are pushed. |
Sorry, something went wrong.
yomete
force-pushed
the
utilization-context-menu
branch
from
1795304 to
bd0925f
Compare
February 26, 2025 15:25
metalmatze
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that clicking on a series in the utilization metrics graph highlights the series using a new selectedSeries queryParams. The previous method of using the query matchers filters away other series instead of simply just highlighting the clicked one.
Related PRs:
area/ui: add Modify the utilization metrics graph to show multiple series
area/ui: strip attributes from context menu