ui: Query validation for icicle chart visualization - #5633
Merged
manojVivek merged 7 commits intoMay 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
✅ Meticulous spotted visual differences in 2 of 304 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~4 hours of user flows against your PR. Last updated for commit 877e301. This comment will update as new commits are pushed. |
Sorry, something went wrong.
metalmatze
reviewed
May 6, 2025
Comment thread
ui/packages/shared/profile/src/ProfileIcicleGraph/index.tsx
Outdated
|
|
||
| export const validateIcicleChartQuery = (profileSource: MergedProfileSource) => { | ||
| const isNonDelta = profileSource.ProfileType().delta !== true; | ||
| const isDurationTooLong = profileSource.mergeTo - profileSource.mergeFrom > 10000; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Let's make it a high limit. I've successfully looked at 10+ seconds.
How about a minute for now?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, sounds good. Will update it.
Sorry, something went wrong.
metalmatze
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some validations on the query before querying for flamecharts and renders appropriate error message in the UI.
Screenshots:
Valid Query:
Invalid Queries: