pkg/query: Introduce value-offset - #5651
Conversation
Sorry, something went wrong.
Value offset allows each frame to be rendered in parallel by the frontend instead of recursively. Value offset determines the X offset, the depth of the frame the Y offset, and the cumulative the width. This is the last piece missing that will allow the frontend to do this.
|
✅ Meticulous spotted 0 visual differences across 426 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit a4033a6. This comment will update as new commits are pushed. |
Sorry, something went wrong.
| parent: row, | ||
| valueOffset: valueOffset, | ||
| }) | ||
| valueOffset += fb.builderCumulative.Value(cr) |
There was a problem hiding this comment.
Ok. So the valueOffset is the offset from the other children relative to the parent's cumulative value, right?
I just wanted to verify that we're not passing the pixel from the frontend and performing some x-y axis math in the backend.
This makes sense to me.
Sorry, something went wrong.
There was a problem hiding this comment.
correct it's the value relative to the total, the frontend can then use that to calculate the position based on the available pixel space
Sorry, something went wrong.
Value offset allows each frame to be rendered in parallel by the frontend instead of recursively. Value offset determines the X offset, the depth of the frame the Y offset, and the cumulative the width.
This is the last piece missing that will allow the frontend to do this.