ui: Ensure Flame Graph is reset on all toolbar interactions - #5953
Conversation
Sorry, something went wrong.
Now resets flame graph state on filter and group-by changes for improved consistency. Renames useResetStateOnNewSearch to useResetFlameGraphState and updates all references. Removes unused curPath state and related props from visualization and dashboard components.
|
✅ Meticulous spotted 0 visual differences across 472 screens tested: view results. Meticulous evaluated ~5 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 3275509. This comment will update as new commits are pushed. |
Sorry, something went wrong.
| profileSource: ProfileSource; | ||
| total: bigint; | ||
| filtered: bigint; | ||
| curPath: string[]; |
There was a problem hiding this comment.
Doing some cleanups here as we no longer need these props.
Sorry, something went wrong.
|
|
||
| const { | ||
| curPath, | ||
| setCurPath, |
There was a problem hiding this comment.
Doing some cleanups here as we no longer need these props.
Sorry, something went wrong.
manojVivek
left a comment
There was a problem hiding this comment.
Lgtm!
Sorry, something went wrong.
This PR ensures that we now reset the Flame Graph on Filters and Level of Profiling changes. I thought it'd be a good idea to rename the useResetStateOnNewSearch hook to useResetFlameGraphState since that reflects/explains more what happens in the hook.