Conversation
Sorry, something went wrong.
|
✅ Meticulous spotted 0 visual differences across 407 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit a6211f9. This comment will update as new commits are pushed. |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR adds demangling support for already-symbolized profiles that contain mangled C++ or Rust function names. The implementation threads a demangler through the query path to demangle function names when decoding encoded location data.
Changes:
- Added demangler parameter to DecodeInto function to demangle function names during profile decoding
- Integrated demangler into the parcacol Querier to enable demangling at query time
- Updated production code to initialize and pass a default demangler to the Querier
- Updated all test files to pass nil for the demangler parameter
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| pkg/profile/decode.go | Added demangler parameter to DecodeInto and implemented demangling of function names |
| pkg/profile/encode_test.go | Updated DecodeInto call to pass nil demangler |
| pkg/parcacol/querier.go | Added demangler field to Querier struct and threaded it through to DecodeInto calls |
| pkg/parca/parca.go | Added import for demangle package and initialized default demangler for production use |
| pkg/parca/parca_test.go | Updated test NewQuerier calls to pass nil demangler |
| pkg/query/sources_test.go | Updated test NewQuerier call to pass nil demangler |
| pkg/query/query_test.go | Updated test NewQuerier calls to pass nil demangler |
| pkg/query/columnquery_test.go | Updated test NewQuerier calls to pass nil demangler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
No description provided.