pkg/scrape: Never block discovery with scrapes - #6327
Merged
brancz merged 1 commit intoApr 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The theory is that either scraping or pushing data might be keeping scrapers from updating their discovered targets. This holds target group locks for as short as possible and adds timeouts and the right contexts in various places.
thorfour
approved these changes
Apr 14, 2026
Copy link
Copy Markdown
|
✅ Meticulous spotted 0 visual differences across 274 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit b86f59b pkg/scrape: Never block discovery with scrapes. This comment will update as new commits are pushed. |
Sorry, something went wrong.
metalmatze
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theory is that either scraping or pushing data might be keeping scrapers from updating their discovered targets. This holds target group locks for as short as possible and adds timeouts and the right contexts in various places.