fix #432: cloud path is not working in Windows due to absolute file path protocol - #449
Open
rjcodedev wants to merge 2 commits into
Open
fix #432: cloud path is not working in Windows due to absolute file path protocol#449rjcodedev wants to merge 2 commits into
rjcodedev wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…olute paths protocol
Copy link
Copy Markdown
Thanks for opening this pull request!
|
Sorry, something went wrong.
mtrezza
requested changes
Jun 12, 2024
Comment thread
index.js
Comment on lines
+13
to
+15
| cloud: function () { | ||
| import('./cloud/main.js'); | ||
| }, |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This would ignore the env var; could you refactor? I think the path can be set in an OS agnostic way, using the url lib, instead of __dirname and for example url.fileURLToPath.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue fix #432 for windows and it also work for linux , macos too