WIP refactor!: gorm V2 - #644
Open
remyoster wants to merge 7 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
moul
reviewed
Mar 11, 2021
Comment thread
go/pkg/pwdb/db.go
moul
reviewed
Mar 11, 2021
Comment thread
go/pkg/pwdb/migrations.go
moul
reviewed
Mar 11, 2021
Comment thread
rules.mk
Copy link
Copy Markdown
Member
|
except for the few comments, it looks very good! |
Sorry, something went wrong.
remyoster
force-pushed
the
dev/roster/gorm_v2
branch
3 times, most recently
from
9f7081f to
501c021
Compare
March 12, 2021 13:25
remyoster
commented
Mar 12, 2021
Comment thread
go/cmd/pathwar/api.go
remyoster
force-pushed
the
dev/roster/gorm_v2
branch
from
501c021 to
7854dee
Compare
March 12, 2021 13:29
remyoster
commented
Mar 12, 2021
Comment thread
api/pwdb.proto
Comment on lines
+189
to
+193
| // belongs to | ||
| int64 user_id = 200 [(gogoproto.customname) = "UserID", (gogoproto.moretags) = "gorm:\"index\""]; | ||
| User user = 201 [(gogoproto.moretags) = "gorm:\"foreignKey:UserID;references:ID\""]; | ||
| // has one | ||
| User active_user = 202 [(gogoproto.moretags) = "gorm:\"foreignKey:ActiveTeamMemberID;references:ID\""]; |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
ForeignKey constraint fails here -> need to investigate or
maybe need to rethink the model association and use a enum to mark a team_member as the active one ?
Sorry, something went wrong.
moul
reviewed
Mar 16, 2021
Comment thread
go/pkg/pwdb/db.go
Outdated
moul
reviewed
Mar 22, 2021
Comment thread
go/cmd/pathwar/api.go
Outdated
remyoster
force-pushed
the
dev/roster/gorm_v2
branch
2 times, most recently
from
8ed5714 to
73d0b40
Compare
March 31, 2021 09:36
djale1k
suggested changes
Apr 12, 2021
Comment thread
go/pkg/pwapi/api_admin-challenge-redump.go
Comment thread
go/pkg/pwapi/api_challenge-subscription-validate.go
Comment thread
go/pkg/pwdb/errors.go
Outdated
Comment thread
go/pkg/pwdb/helpers.go
Closed
Merged
moul-bot
force-pushed
the
dev/roster/gorm_v2
branch
2 times, most recently
from
a35ed7a to
baec25f
Compare
February 4, 2022 22:42
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul-bot
force-pushed
the
dev/roster/gorm_v2
branch
from
baec25f to
a4e093f
Compare
February 10, 2022 00:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.