FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(table): add example of modifier by christiemolloy · Pull Request #2065 · patternfly/patternfly · GitHub

/ patternfly Public

fix(table): add example of modifier - #2065

Merged
mcoker merged 2 commits into
patternfly:masterfrom
christiemolloy:iss2048
Jul 17, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(table): add example of modifier#2065
mcoker merged 2 commits into
patternfly:masterfrom
christiemolloy:iss2048

Conversation

christiemolloy commented Jul 16, 2019

Copy link
Copy Markdown
Member

closes #2048

@KendraMar I added an example of how to make column headers wrap. We should create a new issue if you would like to be able to set max-widths on the columns.

christiemolloy commented Jul 16, 2019
View reviewed changes
Comment thread src/patternfly/components/Table/docs/table-headers-wrap.md

| Class | Applied to | Outcome |
| -- | -- | -- |
| `.pf-m-wrap` | `<th>`, `<td>` | Modifies content to wrap. | No newline at end of file

christiemolloy Jul 16, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mcoker not sure if its necessary to be on the <td> here because the td wraps by default. Only thead has white-space: nowrap; set on it. Maybe I'm missing something.

mcoker Jul 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it's because <td> is valid in a <thead>

patternfly-build commented Jul 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Deploy preview for pf-next ready!

Built with commit c9d182e

https://deploy-preview-2065--pf-next.netlify.com

mcoker approved these changes Jul 16, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🥇

mcarrano approved these changes Jul 17, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks fine to me.

mcoker merged commit 5da03f0 into patternfly:master Jul 17, 2019

patternfly-build commented Jul 17, 2019

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.21.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

mcoker mentioned this pull request Jul 23, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
+1 more reviewer
mcarrano mcarrano approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL