FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(card): added missing body color variable by Mash707 · Pull Request #7756 · patternfly/patternfly · GitHub

/ patternfly Public

fix(card): added missing body color variable - #7756

Open
Mash707 wants to merge 2 commits into
patternfly:mainfrom
Mash707:card-undefined-color-variable
ConversationCommits (2)ChecksFiles changed
Open

fix(card): added missing body color variable#7756
Mash707 wants to merge 2 commits into
patternfly:mainfrom
Mash707:card-undefined-color-variable

Conversation

Mash707 commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Fixes #7386

patternfly-build commented Aug 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-7756.surge.sh

A11y report: https://pf-pr-7756-a11y.surge.sh

srambach approved these changes Aug 27, 2025
View reviewed changes

srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍🏻 thanks!

mcoker requested changes Aug 27, 2025
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great, but since this is changing the card body's text color from inherit to our default color, and cards are used quite a bit, would you mind adding inherit as a fallback for the body text color to give users a way to revert this change in case they were relying on inherit?

patternfly/src/patternfly/components/Card/card.scss

Line 445 in a9c8f5b

color: var(--#{$card}__body--Color);

If you chnage that to color: var(--#{$card}__body--Color, inherit); then someone can revert this change by setting --#{$card}__body--Color: initial;.

Mash707 requested a review from mcoker August 28, 2025 19:28

github-actions Bot commented Oct 31, 2025

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 60 days.

github-actions Bot added the Stale label Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lboehling Awaiting requested review from lboehling
mcoker Awaiting requested review from mcoker
1 more reviewer
srambach srambach approved these changes
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Card - Undefined color variable

4 participants

Back | FazBrowse Home | New Git URL