FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(button): run favorite icon animation only on click or keyboard activation. by tarunvashishth · Pull Request #8152 · patternfly/patternfly · GitHub

/ patternfly Public

fix(button): run favorite icon animation only on click or keyboard activation. #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarunvashishth wants to merge 4 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 7 Commits 4 Checks 1 Files changed
Open

fix(button): run favorite icon animation only on click or keyboard activation. #8152

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13ee506
fix(button): run favorite icon animation only on focus
tarunvashishth Feb 18, 2026
e8d9eff
fix(button): trigger favorite animation on focus and active
tarunvashishth Feb 19, 2026
f54dbe3
chore(button): remove docs-only changes from favorite animation fix
tarunvashishth Feb 19, 2026
7a2f963
fix(button): restore favorite animation for keyboard activation
tarunvashishth Feb 19, 2026
File filter

Filter by extension

Filter by extension .scss  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
17 changes: 16 additions & 1 deletion src/patternfly/components/Button/button.scss
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@
--#{$button}--m-favorited--hover__icon--Color: var(--pf-t--global--color--favorite--hover);
--#{$button}--m-favorited__icon--AnimationDuration: var(--pf-t--global--motion--duration--icon--long);
--#{$button}--m-favorited__icon--AnimationTimingFunction: var(--pf-t--global--motion--timing-function--default);
--#{$button}--m-favorited__icon--AnimationFillMode: both;
--#{$button}__icon--favorite--Opacity: 1;
--#{$button}__icon--favorited--Opacity: 0;
--#{$button}--m-favorited__icon--favorite--Opacity: 0;
Expand Down Expand Up @@ -764,11 +765,25 @@
--#{$button}__icon--favorited--Opacity: var(--#{$button}--m-favorited__icon--favorited--Opacity);
}

// Favorite button will run an animation when favorited
// Keep animation definition on favorited state so focus toggles don't reapply animation-name
&.pf-m-favorited .#{$button}__icon {
animation-name: #{$button}-icon-favorited;
animation-duration: var(--#{$button}--m-favorited__icon--AnimationDuration);
animation-play-state: paused;
animation-timing-function: var(--#{$button}--m-favorited__icon--AnimationTimingFunction);
animation-fill-mode: var(--#{$button}--m-favorited__icon--AnimationFillMode);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// Run favorite animation when interaction logic applies a one-shot class.
// Keep non-scripted fallback triggers for existing integrations:
// - :focus-visible supports keyboard activation flows (e.g. React click on key release).
// - :focus:not(:focus-visible) covers pointer focus.
// - :active covers press interactions.
&.pf-m-is-animating .#{$button}__icon,
&.pf-m-favorited:focus-visible .#{$button}__icon,
&.pf-m-favorited:focus:not(:focus-visible) .#{$button}__icon,
&.pf-m-favorited:active .#{$button}__icon {
animation-play-state: running;
}

&.pf-m-settings {
Expand Down
Back | FazBrowse Home | New Git URL