FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(docked nav expandable): remove ellipsis on mobile by jcmill · Pull Request #8570 · patternfly/patternfly · GitHub

/ patternfly Public

fix(docked nav expandable): remove ellipsis on mobile - #8570

Merged
mcoker merged 1 commit into
patternfly:mainfrom
jcmill:bug/8569-mobile-docked-nav-expandable
Aug 26, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(docked nav expandable): remove ellipsis on mobile#8570
mcoker merged 1 commit into
patternfly:mainfrom
jcmill:bug/8569-mobile-docked-nav-expandable

Conversation

jcmill commented Aug 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #8569

This fixes the expandable-item indicator icon (ellipsis) incorrectly showing in the docked nav on mobile view. Because the nav is fully expanded by default on mobile, this sets the display to none and reverts it in the desktop breakpoint (following a "mobile first" approach).

Summary by CodeRabbit

  • Bug Fixes
    • Improved the docked navigation layout by hiding the expandable icon on smaller screens.
    • Restored the icon on desktop-width displays for a more appropriate responsive experience.

jcmill requested a review from mcoker August 26, 2026 14:49

coderabbitai Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ec4149e-43f9-49d4-a1be-4d0a9afbce81

📥 Commits

Reviewing files that changed from the base of the PR and between 1580d6d and 8f2cf97.

📒 Files selected for processing (1)
  • src/patternfly/components/Nav/nav.scss

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The docked navigation now hides expandable icons by default and restores them at desktop widths.

Changes

Docked navigation responsive visibility

Layer / File(s) Summary
Responsive expandable icon visibility
src/patternfly/components/Nav/nav.scss		 The docked navigation hides .nav__link-expandable-icon by default and restores it with display: revert at the desktop breakpoint.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8f2cf

This localized navigation styling change is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining.

Suggested reviewers: mcoker

🚥 Pre-merge checks | ✅ 4 ✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows the conventional commit format and accurately describes hiding the docked navigation ellipsis on mobile.
Linked Issues check ✅ Passed The change satisfies issue #8569 by hiding the expandable-item icon by default on mobile and restoring it at the desktop breakpoint.
Out of Scope Changes check ✅ Passed The changes are limited to the docked navigation icon display behavior and are directly related to issue #8569.

Warning

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

patternfly-build commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8570.surge.sh

A11y report: https://pf-pr-8570-a11y.surge.sh

mcoker approved these changes Aug 26, 2026
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

mcoker merged commit 098f779 into patternfly:main Aug 26, 2026
6 checks passed

patternfly-build commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.38 🎉

The release is available on:

Your semantic-release bot 📦🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Docked Nav Expandable - Visible ellipsis on mobile

3 participants

Back | FazBrowse Home | New Git URL