feat: Add performance marks for reporting - #1455
Merged
castastrophe merged 31 commits intoMar 30, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
zhawkins
approved these changes
Mar 17, 2021
…tternfly-elements into feat-add-performance-marks
…tternfly-elements into feat-add-performance-marks
…to feat-add-performance-marks
castastrophe
commented
Mar 22, 2021
Comment thread
elements/pfelement/src/pfelement.js
Outdated
castastrophe
enabled auto-merge (squash)
March 23, 2021 16:19
zhawkins
reviewed
Mar 23, 2021
Comment thread
package.json
Outdated
…tternfly-elements into feat-add-performance-marks
…tternfly-elements into feat-add-performance-marks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for performance tracking on each component
Performance marks will be added via PFElement when added to the DOM and report on the time between that event and first render. These reports will show up in LightHouse or the Performance tab.
Preview
Link(s) to demo page(s) where this element can be viewed:
Testing instructions
Browser requirements
Ready-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!