FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: gracefully fail on duplicate registration by castastrophe · Pull Request #1728 · patternfly/patternfly-elements · GitHub

feat: gracefully fail on duplicate registration - #1728

Merged
castastrophe merged 25 commits into
masterfrom
feat-gracefully-fail-dupe-definition
Jul 28, 2021
Merged

feat: gracefully fail on duplicate registration #1728
castastrophe merged 25 commits into
masterfrom
feat-gracefully-fail-dupe-definition

Conversation

castastrophe commented Jul 27, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

Wrap custom element registration in a try/catch to prevent noisy or blocking failures from preventing component upgrades.

Testing instructions

  • Load the same class twice on the page, no errors should be thrown (AT)
  • Load two separate classes with the same tag name, no errors should be thrown (AT)
  • Load a components with different versions defined, turn on debugging logs; should see a warning (AT)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Changelog updated (required for fix and feat changes).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

castastrophe added feature New feature or request ready: branch testing Test the component from a user-perspective. Try to break it! ready: code review Ready for code review! ready: browser testing Test the component in the supported browser environments. priority: low Severity level: 3 labels Jul 27, 2021

netlify Bot commented Jul 27, 2021
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: b92836c

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/6100d8df165c150008c52e86

😎 Browse the preview: https://deploy-preview-1728--patternfly-elements.netlify.app

castastrophe changed the title Feat gracefully fail dupe definition feat: gracefully fail on duplicate registration Jul 27, 2021
github-actions Bot added functionality Functionality, typically pertaining to the JavaScript. tools Development and build tools labels Jul 27, 2021
github-actions Bot added the docs Documentation updates label Jul 27, 2021
github-actions Bot removed the tools Development and build tools label Jul 27, 2021
castastrophe requested a review from mwcz July 27, 2021 20:18
github-actions Bot added the tests Related to testing label Jul 28, 2021
castastrophe changed the title feat: gracefully fail on duplicate registration feat: gracefully fail on duplicate registration Jul 28, 2021
castastrophe removed ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. labels Jul 28, 2021
github-actions Bot added the AT passed Automated testing has passed label Jul 28, 2021
castastrophe enabled auto-merge (squash) July 28, 2021 04:11

mwcz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Less Greater Than More

castastrophe disabled auto-merge July 28, 2021 14:41
castastrophe enabled auto-merge (squash) July 28, 2021 14:41
castastrophe removed the ready: code review Ready for code review! label Jul 28, 2021
castastrophe merged commit d3ea7fa into master Jul 28, 2021
castastrophe deleted the feat-gracefully-fail-dupe-definition branch July 28, 2021 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed docs Documentation updates feature New feature or request functionality Functionality, typically pertaining to the JavaScript. priority: low Severity level: 3 tests Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL