FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(get-started): Updates get started contribute pages. by edonehoo · Pull Request #3926 · patternfly/patternfly-org · GitHub

/ patternfly-org Public

docs(get-started): Updates get started contribute pages. - #3926

Merged
jessiehuff merged 10 commits into
patternfly:v6from
edonehoo:iss3921
May 22, 2024
ConversationCommits (10)ChecksFiles changed
Merged

docs(get-started): Updates get started contribute pages.#3926
jessiehuff merged 10 commits into
patternfly:v6from
edonehoo:iss3921

Conversation

edonehoo commented Mar 21, 2024

Copy link
Copy Markdown
Collaborator

Closes #3921

edonehoo self-assigned this Mar 21, 2024

edonehoo commented Mar 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

note: In this first pass I tried combining the pages, but this is an idea that I'd like to hear feedback on. Happy to iterate further! also, I know that we plan to enhance/build out on these, so we can do that in this pr or a followup

patternfly-build commented Mar 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://patternfly-org-pr-3926-site.surge.sh

srambach reviewed Apr 23, 2024
View reviewed changes

srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like combining the pages. ❤️ I do have some individual comments.

  • The Figma kit isn't mentioned - should it be?
  • I'm not sure about formatting the repo names as code. It's not really code per se, and it makes it harder to see that those are links.
  • In general, I find this page more difficult to scan and understand than the old one, which had a bit less just text and more lists.

Comment thread packages/documentation-site/patternfly-docs/content/get-started/contribute.md Outdated
Comment thread packages/documentation-site/patternfly-docs/content/get-started/contribute.md Outdated
Comment thread packages/documentation-site/patternfly-docs/content/get-started/contribute.md Outdated
- [Core contribution guidelines](https://github.com/patternfly/patternfly#guidelines-for-css-development)
- [React contribution guidelines](https://github.com/patternfly/patternfly-react/blob/main/CONTRIBUTING.md#contribution-process)

### File a bug

srambach Apr 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I find the old version with the bullets a lot easier to read.

edonehoo mentioned this pull request May 7, 2024
Open
andrew-ronaldson approved these changes May 8, 2024
View reviewed changes

andrew-ronaldson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks

edonehoo commented May 8, 2024

Copy link
Copy Markdown
Collaborator Author

@srambach made some updates from your feedback - ty!

RE contributing to the Figma kit - is there an established process for this yet?

edonehoo mentioned this pull request May 8, 2024
Merged
srambach approved these changes May 21, 2024
View reviewed changes

srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! I am not sure about guidelines for the Figma kit. But that can be added later.

jessiehuff merged commit 091ab6d into patternfly:v6 May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

andrew-ronaldson andrew-ronaldson approved these changes
+2 more reviewers
srambach srambach approved these changes
jessiehuff jessiehuff approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

edonehoo

Labels

Content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL