fix(Wizard): allow dynamic step update - #10748
Merged
dlabaj merged 1 commit intoJul 16, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Preview: https://patternfly-react-pr-10748.surge.sh A11y report: https://patternfly-react-pr-10748-a11y.surge.sh |
Sorry, something went wrong.
tlabaj
requested review from
a team,
thatblindgeye and
tlabaj
and removed request for
a team
July 15, 2024 21:03
thatblindgeye
approved these changes
Jul 16, 2024
thatblindgeye
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Not blocking to get it in for this PR, but might be good to have some test(s) for this behavior. If anything we can create a followup to keep it in mind.
Sorry, something went wrong.
dlabaj
approved these changes
Jul 16, 2024
dlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9752
Adds two useEffect blocks to update steps when the initial children change, and reset the active step index when the children change.
This codesandbox from the issue can be pasted into one of our Wizard examples to verify the fix.