| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting. Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: f622bdcc-8377-416f-ba55-a7e61430ab2c 📥 CommitsReviewing files that changed from the base of the PR and between ac6b113 and 52b349d. 📒 Files selected for processing (15)
WalkthroughReplaces imports and JSX usages of BarsIcon with RhUiMenuBarsIcon across example, demo, markdown, and integration files. No API, runtime behavior, or exported/public entity changes. ChangesIcon replacement: BarsIcon → RhUiMenuBarsIcon
Sequence Diagram(s)(omitted — edits are import/usage replacements without multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Suggested reviewers
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
There was a problem hiding this comment.
packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md (1)🤖 Prompt for all review comments with AI agents10-10: Change line 10 to use dist/esm for consistency with other imports in this file.
All other icon imports in NotificationDrawer.md use dist/esm; line 10's dist/js import creates unnecessary inconsistency.
🤖 Prompt for AI AgentsVerify each finding against the current code and only fix it if needed. In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md` at line 10, Update the import for RhUiMenuBarsIcon to match the other icon imports by changing the module path from '@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build, i.e. import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the NotificationDrawer.md imports consistent with the rest of the file.
Verify each finding against the current code and only fix it if needed. Nitpick comments: In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md`: - Line 10: Update the import for RhUiMenuBarsIcon to match the other icon imports by changing the module path from '@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build, i.e. import RhUiMenuBarsIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the NotificationDrawer.md imports consistent with the rest of the file.
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 32b2fb26-83c4-46db-8e06-f6152a9e50f3
📥 CommitsReviewing files that changed from the base of the PR and between 69b6225 and 0252229.
📒 Files selected for processing (15)
Sorry, something went wrong.
|
Preview: https://pf-react-pr-12377.surge.sh A11y report: https://pf-react-pr-12377-a11y.surge.sh |
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What: towards #12244
Summary
Replaces BarsIcon with RhUiMenuBarsIcon (rh-ui-menu-bars-icon) in components, documentation, and the integration demo app so the menu/bars icon uses the Red Hat UI asset.
Changes
Scope
Summary by CodeRabbit
Documentation
Chores
Closes #12397