fix(login): added login subtitle by dtaylor113 · Pull Request #1696 · patternfly/patternfly-react · GitHub

PatternFly-React preview: https://1696-pr-patternfly-react-patternfly.surge.sh

Hi @redallen,
I was able to add the 'popup example' link to the Login example. It now appears under 'Demos' ('Components' see comment below):

Some Questions:

I still do not know what is causing the SyntaxError, it's something in the render() function.
Is there a way to have the Login appear under components with the props, and just have the Login 'popup example' appear under Demos?

Thanks

Buble is what is complaining about something in your render() function. Your code gets some regexs run on it before being handed to Buble in liveEdit.js. Print toParse and then pass it to Buble via require( 'buble' ).transform(toParse) to debug.
Not quite sure if you want it in both places, only one place, or to have a "popout demo" while remaining under components. All are possible.

2. Not quite sure if you want it in both places, only one place, or to have a "popout demo" while remaining under components. All are possible.

Changing it to section: "components" put it under the Components section -thanks

Hi @jschuler, @tlabaj, any progress on this review? -thanks
Pls let me know if I identified the correct reviewers, I'm not sure who should review what.
Thanks,

Dave

Hi @jschuler, @tlabaj, pls let me know if there is another dev I should add to the Reviewers list?
Thanks :-)

After you push the md file change I'll approve!

Codecov Report

Merging #1696 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1696   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         601      601           
  Lines        6645     6645           
  Branches       72       72           
=======================================
  Hits         5499     5499           
  Misses       1119     1119           
  Partials       27       27

Flag	Coverage Δ
#patternfly3	84.87% <ø> (ø)	⬆️
#patternfly4	79.42% <ø> (ø)	⬆️
#patternflymisc	95.68% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
...t-core/src/components/LoginPage/LoginMainHeader.js	100% <ø> (ø)	⬆️
...4/react-core/src/components/LoginPage/LoginPage.js	100% <ø> (ø)	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0df56d...962aa03. Read the comment docs.

Codecov Report

Merging #1696 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1696   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         603      603           
  Lines        6670     6670           
  Branches       76       76           
=======================================
  Hits         5520     5520           
  Misses       1120     1120           
  Partials       30       30

Flag	Coverage Δ
#patternfly3	84.87% <ø> (ø)	⬆️
#patternfly4	79.46% <ø> (ø)	⬆️
#patternflymisc	95.68% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
...t-core/src/components/LoginPage/LoginMainHeader.js	100% <ø> (ø)	⬆️
...4/react-core/src/components/LoginPage/LoginPage.js	100% <ø> (ø)	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0885c...11802a8. Read the comment docs.

Sorry to make you have to change your MD file again. Looks great!

Thanks @redallen, @tlabaj or @jschuler can you please review? -thanks

LGTM! @mceledonia can you verify? https://1696-pr-patternfly-react-patternfly.surge.sh/patternfly-4/components/loginpage/simpleloginpage/

LGTM as well!

LGTM

👍

Please make this property optional

Ok, updated, thanks

Thanks @dtaylor113! LGTM

LGTM

dtaylor113 requested review from amarie401 and tlabaj April 3, 2019 15:16

dtaylor113 force-pushed the login-header branch from 4b305c9 to 2117695 Compare April 3, 2019 15:54

dtaylor113 force-pushed the login-header branch from 81e5d1b to a1f52e7 Compare April 3, 2019 19:23

patternfly deleted a comment from redallen Apr 3, 2019

patternfly deleted a comment from codecov-io Apr 3, 2019

amarie401 requested a review from jschuler April 3, 2019 21:27

patternfly deleted a comment from codecov-io Apr 4, 2019

tlabaj added PF4 labels Apr 8, 2019

jschuler mentioned this pull request Apr 8, 2019

PF4 docs #1724

Closed

12 tasks

tlabaj assigned kmcfaul Apr 15, 2019

tlabaj requested a review from christiemolloy April 15, 2019 17:11

tlabaj added ux review labels Apr 15, 2019

redallen suggested changes Apr 15, 2019

View reviewed changes

Comment thread packages/patternfly-4/react-core/src/components/LoginPage/LoginPage.md Outdated

redallen approved these changes Apr 15, 2019

View reviewed changes

redallen suggested changes Apr 15, 2019

View reviewed changes

dtaylor113 force-pushed the login-header branch from a1f52e7 to c83b33e Compare April 15, 2019 18:34

redallen previously approved these changes Apr 15, 2019

View reviewed changes

fix(login): added login subtitle

e6a26f4

dtaylor113 dismissed redallen’s stale review via 962aa03 April 16, 2019 15:43

dtaylor113 force-pushed the login-header branch from c83b33e to 962aa03 Compare April 16, 2019 15:43

redallen previously approved these changes Apr 16, 2019

View reviewed changes

dtaylor113 assigned tlabaj Apr 18, 2019

christiemolloy previously approved these changes Apr 18, 2019

View reviewed changes

mcoker previously approved these changes Apr 18, 2019

View reviewed changes

dgutride suggested changes Apr 18, 2019

View reviewed changes

Added 'popout example' link

11802a8

dtaylor113 dismissed stale reviews from mcoker, christiemolloy, and redallen via 11802a8 April 18, 2019 19:28

dtaylor113 force-pushed the login-header branch from 962aa03 to 11802a8 Compare April 18, 2019 19:28

redallen approved these changes Apr 18, 2019

View reviewed changes

dgutride approved these changes Apr 18, 2019

View reviewed changes

mcarrano added ux approved and removed ux review labels Apr 18, 2019

tlabaj suggested changes Apr 18, 2019

View reviewed changes

tlabaj approved these changes Apr 18, 2019

View reviewed changes

tlabaj merged commit 4864eb6 into patternfly:master Apr 18, 2019

                 footerListItems?: ReactNode;
                 footerListVariants?: OneOf<typeof LoginListVariant, keyof typeof LoginListVariant>;
                 loginTitle: string;
+                loginSubtitle: string;

fix(login): added login subtitle by dtaylor113 · Pull Request #1696 · patternfly/patternfly-react · GitHub

Uh oh!

fix(login): added login subtitle - #1696

fix(login): added login subtitle#1696tlabaj merged 2 commits intopatternfly:masterpatternfly/patternfly-react:masterfrom dtaylor113:login-headerdtaylor113/patternfly-react:login-headerCopy head branch name to clipboard

Conversation

dtaylor113 commented Apr 3, 2019

Uh oh!

patternfly-build commented Apr 3, 2019

Uh oh!

dtaylor113 commented Apr 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

redallen commented Apr 3, 2019

Uh oh!

dtaylor113 commented Apr 3, 2019

Uh oh!

dtaylor113 commented Apr 5, 2019

Uh oh!

dtaylor113 commented Apr 15, 2019

Uh oh!

Uh oh!

redallen left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-io commented Apr 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

redallen left a comment

Choose a reason for hiding this comment

Uh oh!

dtaylor113 commented Apr 16, 2019

Uh oh!

mcarrano commented Apr 18, 2019

Uh oh!

mceledonia commented Apr 18, 2019

Uh oh!

christiemolloy left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

dgutride Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

dtaylor113 Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

fix(login): added login subtitle#1696
tlabaj merged 2 commits into
patternfly:masterfrom
dtaylor113:login-header

dtaylor113 commented Apr 3, 2019 •
edited
Loading

codecov-io commented Apr 15, 2019 •
edited
Loading

codecov-io commented Apr 16, 2019 •
edited
Loading