FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(grid): add missing props in d.ts by boaz0 · Pull Request #1749 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(grid): add missing props in d.ts - #1749

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:fixes_1718
Apr 23, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(grid): add missing props in d.ts#1749
tlabaj merged 1 commit into
patternfly:masterfrom
boaz0:fixes_1718

Conversation

boaz0 commented Apr 11, 2019

Copy link
Copy Markdown
Member

What:

fixes #1718

Added the span, sm, md, lg and xl props in the d.ts file

patternfly-build commented Apr 11, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1749-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Apr 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         598      598           
  Lines        6629     6629           
  Branches       72       72           
=======================================
  Hits         5484     5484           
  Misses       1118     1118           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3b70...7e115d3. Read the comment docs.

codecov-io commented Apr 11, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1749   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         598      598           
  Lines        6629     6629           
  Branches       72       72           
=======================================
  Hits         5484     5484           
  Misses       1118     1118           
  Partials       27       27
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.34% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b3b70...6764a37. Read the comment docs.

fix(grid): add missing props in d.ts
6764a37 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
tlabaj self-assigned this Apr 15, 2019
tlabaj approved these changes Apr 23, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 35815c2 into patternfly:master Apr 23, 2019

boaz0 commented Apr 23, 2019

Copy link
Copy Markdown
Member Author

Thanks you @tlabaj and @redallen

boaz0 deleted the fixes_1718 branch April 23, 2019 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typescript version of Grid component is missing props

5 participants

Back | FazBrowse Home | New Git URL