| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #1753 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 601 601
Lines 6645 6645
Branches 72 72
=======================================
Hits 5499 5499
Misses 1119 1119
Partials 27 27
Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
PatternFly-React preview: https://1753-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
|
Looks good to me visually. Removing the <pre> solved a lot of typography and spacing issues. Let me know if there is something specific you'd like me to review. |
Sorry, something went wrong.
|
That's all I wanted, verifying the <pre> changes did something. Thanks! |
Sorry, something went wrong.
There was a problem hiding this comment.
🥇
Sorry, something went wrong.
|
PatternFly-React preview: https://1753-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
|
@tlabaj Can you check if your recent DataList changes work in the doc preview that just deployed? |
Sorry, something went wrong.
There was a problem hiding this comment.
👍
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What: Use MDX for docs instead of markdown-remark with our own custom plugins.
Additional issues: If you're a doc maintainer, now your docs are now MDX files. MDX is JSX in markdown, so you have a full-fledged React component to work with inside your MDX file. The minimum to get your examples working is this:
--- title: 'title' cssPrefix: 'pf-c-prefix' --- // Add imports below (need newlines before + after)... import { Avatar } from '@patternfly/react-core'; import avatarImg from './examples/avatarImg.svg'; ## Simple Avatar Example ```js // The following imports are used to make copy-pasting examples possible. They have no effect. import React from 'react'; import { Avatar } from '@patternfly/react-core'; import avatarImg from './examples/avatarImg.svg'; // You can have raw JSX, a function, or class rendered here using react-live <Avatar src={avatarImg} alt="avatar"></Avatar> ``` // You can even render the component outside of the code block to appear inline in the docs! <Avatar src={avatarImg} alt="avatar"></Avatar>