FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build(clipboardcopy): change doc text by redallen · Pull Request #1823 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

build(clipboardcopy): change doc text - #1823

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
redallen:fix/clipboard-docs2
Apr 23, 2019
ConversationCommits (2)ChecksFiles changed
Merged

build(clipboardcopy): change doc text#1823
tlabaj merged 2 commits into
patternfly:masterfrom
redallen:fix/clipboard-docs2

Conversation

redallen commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

What: Resolves #1822

Additional issues:

rebeccaalpert previously approved these changes Apr 22, 2019
View reviewed changes

patternfly-build commented Apr 22, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1823-pr-patternfly-react-patternfly.surge.sh

tlabaj suggested changes Apr 22, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I noticed that the ClipboardCopyProps are not exported in the index.d.ts file. Can you please add that with this PR. Also there are some unused imports in the ClipboardCopy.js file. Can you please clean them up with this PR as well? Thanks!

codecov-io commented Apr 23, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1823 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         606      606           
  Lines        6688     6688           
  Branches       76       76           
=======================================
  Hits         5535     5535           
  Misses       1123     1123           
  Partials       30       30
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.49% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...e/src/components/AboutModal/AboutModalBoxHeader.js 100% <0%> (ø) ⬆️
...ly-4/react-core/src/components/Page/PageSection.js 100% <0%> (ø) ⬆️
...react-core/src/components/AboutModal/AboutModal.js 70.83% <0%> (ø) ⬆️
...e/src/components/AboutModal/AboutModalContainer.js 88.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2caf8a5...3d8e7c5. Read the comment docs.

seanforyou23 approved these changes Apr 23, 2019
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changes look good. While testing this locally, I did notice the following error regarding ClipboardCopyProps.

Interface 'ClipboardCopyProps' incorrectly extends interface 'HTMLProps<HTMLDivElement>'.

Feel free to include those fixes here or in a separate PR.

tlabaj approved these changes Apr 23, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj suggested changes Apr 23, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, could please make that one update from @seanforyou23

tlabaj approved these changes Apr 23, 2019
View reviewed changes

tlabaj left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. We can address the is @seanforyou23 in a separate PR.

tlabaj merged commit 959dfa1 into patternfly:master Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rebeccaalpert rebeccaalpert left review comments
+2 more reviewers
seanforyou23 seanforyou23 approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update read-only ClipboardCopy example to match Core

6 participants

Back | FazBrowse Home | New Git URL