FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(clipboard): remove textarea from clipboard copy by dgutride · Pull Request #1840 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(clipboard): remove textarea from clipboard copy - #1840

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
dgutride:fix-clipboard-copy
Apr 24, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(clipboard): remove textarea from clipboard copy#1840
dlabaj merged 2 commits into
patternfly:masterfrom
dgutride:fix-clipboard-copy

Conversation

dgutride commented Apr 24, 2019 •
edited by dlabaj
Loading

Copy link
Copy Markdown
Member

Fixes #1816

What:

Additional issues:

dgutride force-pushed the fix-clipboard-copy branch from e7d94d6 to a9b7b18 Compare April 24, 2019 18:35

patternfly-build commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1840-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Apr 24, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1840 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #1840      +/-   ##
=========================================
+ Coverage    82.8%   82.8%   +<.01%     
=========================================
  Files         609     609              
  Lines        6711    6712       +1     
  Branches       81      81              
=========================================
+ Hits         5557    5558       +1     
  Misses       1123    1123              
  Partials       31      31
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.63% <75%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...re/src/components/ClipboardCopy/ExpandedContent.js 83.33% <75%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242c835...16a0710. Read the comment docs.

mcoker commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

If you edit the content in the expandable example, if you start adding content anywhere other than the very beginning of the screen, after you type 1 character, the cursor moves back to the beginning of the expandable content.

dlabaj previously approved these changes Apr 24, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj reviewed Apr 24, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You have conflicts

redallen commented Apr 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Just tried Github's web browser merging since the merge was super easy. Let's hope it works!

Edit: It worked. Magical.

dlabaj merged commit 8bb26a2 into patternfly:master Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ClipboardCopy - Remove TextArea

6 participants

Back | FazBrowse Home | New Git URL