FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes demo to show single and multiple expand behavior by dlabaj · Pull Request #1860 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Fixes demo to show single and multiple expand behavior - #1860

Merged
tlabaj merged 5 commits into
patternfly:masterfrom
dlabaj:accordion
Apr 26, 2019
ConversationCommits (5)ChecksFiles changed
Merged

Fixes demo to show single and multiple expand behavior#1860
tlabaj merged 5 commits into
patternfly:masterfrom
dlabaj:accordion

Conversation

dlabaj commented Apr 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the behavior of the accordion for #1387 and makes accordion available to consumers.

Additional issues:
Please merge this PR first #1852 (review) I'll rebase after to get these in.

patternfly-build commented Apr 26, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1860-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Apr 26, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1860 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
- Coverage   82.59%   82.59%   -0.01%     
==========================================
  Files         621      622       +1     
  Lines        6844     6849       +5     
  Branches       93       93              
==========================================
+ Hits         5653     5657       +4     
- Misses       1151     1152       +1     
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.29% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...t-core/src/components/Accordion/AccordionToggle.js 100% <100%> (ø) ⬆️
...ct-table/src/components/Table/utils/headerUtils.js 100% <0%> (ø) ⬆️
...ernfly-4/react-table/src/components/Table/Table.js 88.46% <0%> (ø) ⬆️
...t-table/src/components/Table/utils/transformers.js 100% <0%> (ø) ⬆️
...rc/components/Table/utils/decorators/classNames.js 75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae95e9...2ff69e7. Read the comment docs.

dlabaj requested review from mcarrano and mcoker April 26, 2019 11:58
mcoker previously approved these changes Apr 26, 2019
View reviewed changes
mcarrano previously approved these changes Apr 26, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This now behaves as I expect. Thanks @dlabaj !

tlabaj previously approved these changes Apr 26, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kmcfaul previously approved these changes Apr 26, 2019
View reviewed changes
dlabaj dismissed stale reviews from kmcfaul, tlabaj, mcarrano, and mcoker via 0127879 April 26, 2019 20:13
jessiehuff previously approved these changes Apr 26, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

dgutride previously approved these changes Apr 26, 2019
View reviewed changes
tlabaj previously approved these changes Apr 26, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcoker commented Apr 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@dlabaj can you get rid of the span that wraps the svg? It's not necessary.

dlabaj commented Apr 26, 2019

Copy link
Copy Markdown
Contributor Author

@mcoker sure thing. Doing it now.

dlabaj dismissed stale reviews from tlabaj, dgutride, and jessiehuff via 2ff69e7 April 26, 2019 20:43
tlabaj approved these changes Apr 26, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 6db9335 into patternfly:master Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
kmcfaul kmcfaul left review comments
jschuler Awaiting requested review from jschuler
ibolton336 Awaiting requested review from ibolton336
+4 more reviewers
dgutride dgutride approved these changes
tlabaj tlabaj approved these changes
mcarrano mcarrano left review comments
jessiehuff jessiehuff left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL