fix(charts): Fix chart font stack to use PatternFly core sans-serif font stack - #1865
Merged
tlabaj merged 1 commit intoMay 6, 2019
Merged
fix(charts): Fix chart font stack to use PatternFly core sans-serif font stack#1865tlabaj merged 1 commit into
tlabaj merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://1865-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1865 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 621 621
Lines 6844 6844
Branches 93 93
=======================================
Hits 5653 5653
Misses 1151 1151
Partials 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dlabrecq
approved these changes
Apr 29, 2019
tlabaj
approved these changes
May 2, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1864
What:
Use global_FontFamily_sans_serif variable for chart font stack. Also, correct misspelled 'TYPOGRAPHY' related variable names.