FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(card): Converted card component to typescript by jessiehuff · Pull Request #1885 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(card): Converted card component to typescript - #1885

Merged
tlabaj merged 15 commits into
patternfly:masterfrom
jessiehuff:feat/cardTS
May 20, 2019
ConversationCommits (15)ChecksFiles changed
Merged

feat(card): Converted card component to typescript#1885
tlabaj merged 15 commits into
patternfly:masterfrom
jessiehuff:feat/cardTS

Conversation

jessiehuff commented Apr 29, 2019

Copy link
Copy Markdown
Contributor

Fixes #1884

patternfly-build commented Apr 29, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1885-pr-patternfly-react-patternfly.surge.sh

jessiehuff changed the title Converted card component to typescript feat(card): Converted card component to typescript Apr 29, 2019

codecov-io commented Apr 29, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1885 into master will decrease coverage by <.01%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   81.85%   81.84%   -0.01%     
==========================================
  Files         628      628              
  Lines        7159     7178      +19     
  Branches      250      265      +15     
==========================================
+ Hits         5860     5875      +15     
  Misses       1164     1164              
- Partials      135      139       +4
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.88% <90.69%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Card/CardHeader.tsx 88.88% <88.88%> (ø)
...ly-4/react-core/src/components/Card/CardFooter.tsx 90% <90%> (ø)
...nfly-4/react-core/src/components/Card/CardBody.tsx 91.66% <91.66%> (ø)
...tternfly-4/react-core/src/components/Card/Card.tsx 91.66% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e7cb5...2c93464. Read the comment docs.

redallen previously approved these changes Apr 30, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hooray~!

rebeccaalpert previously approved these changes Apr 30, 2019
View reviewed changes
tlabaj added PF4 labels May 2, 2019
tlabaj suggested changes May 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a few updates needed.

Comment thread packages/patternfly-4/react-core/src/components/Card/CardBody.tsx
Comment thread packages/patternfly-4/react-core/src/components/Card/CardFooter.tsx
Comment thread packages/patternfly-4/react-core/src/components/Card/CardHeader.tsx
Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx

nicolethoen commented May 8, 2019

Copy link
Copy Markdown
Contributor

@jessiehuff can you also add integration tests for this component as outlined on this README?

jessiehuff dismissed stale reviews from rebeccaalpert and redallen via cab8547 May 9, 2019 19:25
redallen suggested changes May 13, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardBody.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardFooter.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardHeader.tsx Outdated
rachael-phillips mentioned this pull request May 13, 2019
Closed
redallen suggested changes May 15, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardBody.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardFooter.tsx Outdated
tlabaj suggested changes May 16, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple of updates needed based on yesterday's discussion.

Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Card/CardBody.tsx Outdated
dlabaj self-assigned this May 17, 2019
tlabaj suggested changes May 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you just update the comments to use sentence case. Thanks

Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx
tlabaj suggested changes May 17, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx
Comment thread packages/patternfly-4/react-core/src/components/Card/CardBody.tsx
Comment thread packages/patternfly-4/react-core/src/components/Card/CardFooter.tsx Outdated
redallen approved these changes May 20, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! 📇

Comment thread packages/patternfly-4/react-core/src/components/Card/Card.tsx
tlabaj approved these changes May 20, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit e3e4170 into patternfly:master May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
rebeccaalpert rebeccaalpert left review comments
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert Card from Javascript to Typescript

8 participants

Back | FazBrowse Home | New Git URL