FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add example styles for charts and alert by dgutride · Pull Request #1889 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Add example styles for charts and alert - #1889

Merged
redallen merged 2 commits into
patternfly:masterfrom
dgutride:add-styles-back
Apr 30, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Add example styles for charts and alert#1889
redallen merged 2 commits into
patternfly:masterfrom
dgutride:add-styles-back

Conversation

dgutride commented Apr 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Also fixes the code example for the docs site
addresses some of: #1724

dgutride requested a review from redallen April 30, 2019 15:31

patternfly-build commented Apr 30, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1889-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Apr 30, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1889 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1889   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <ø> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736f9a8...e04dcf0. Read the comment docs.

dlabaj reviewed Apr 30, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-charts/src/components/ChartArea/examples/chart-area.scss
}

.chart-title {
margin-bottom: 25px;

dlabaj Apr 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we be using SASS variables for things that are common in overflow, title, container, margin, etc?

dgutride Apr 30, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this was just ported from previous examples and deleted, we can refactor later if you'd like

dlabaj Apr 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay we can do it later thought this was something new. Thanks.

redallen merged commit c6fec71 into patternfly:master Apr 30, 2019
redallen mentioned this pull request May 1, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
jschuler jschuler approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL