FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(TextInput): Convert text input to TypeScript by rebeccaalpert · Pull Request #1914 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(TextInput): Convert text input to TypeScript - #1914

Merged
tlabaj merged 7 commits into
patternfly:masterfrom
rebeccaalpert:textinput-typescript
Jun 5, 2019
ConversationCommits (7)ChecksFiles changed
Merged

feat(TextInput): Convert text input to TypeScript#1914
tlabaj merged 7 commits into
patternfly:masterfrom
rebeccaalpert:textinput-typescript

Conversation

rebeccaalpert commented May 2, 2019

Copy link
Copy Markdown
Member

Fixes #1908.

patternfly-build commented May 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1914-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1914 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
+ Coverage   81.09%   81.14%   +0.04%     
==========================================
  Files         643      644       +1     
  Lines        7706     7721      +15     
  Branches      451      453       +2     
==========================================
+ Hits         6249     6265      +16     
+ Misses       1257     1256       -1     
  Partials      200      200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.01% <100%> (+0.11%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...fly-4/react-core/src/components/TextInput/index.ts 100% <100%> (ø)
.../react-core/src/components/TextInput/TextInput.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c04803...d70a2a2. Read the comment docs.

nicolethoen commented May 8, 2019

Copy link
Copy Markdown
Contributor

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

rachael-phillips mentioned this pull request May 13, 2019
Closed

rebeccaalpert commented May 14, 2019

Copy link
Copy Markdown
Member Author

Added demo and tests.

patternfly-build commented May 15, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1914-pr-patternfly-react-patternfly.surge.sh

rebeccaalpert commented May 16, 2019

Copy link
Copy Markdown
Member Author

Updated enum typing as discussed in meeting.

rebeccaalpert requested review from dlabaj and tlabaj May 16, 2019 14:42
dlabaj requested changes May 16, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few comments. Let me know if you have any questions.

Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.tsx
Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.tsx
Comment thread packages/patternfly-4/react-integration/cypress/integration/textinputdemo.spec.ts
Comment thread packages/patternfly-4/react-table/src/components/Table/__snapshots__/Table.test.js.snap
dlabaj self-assigned this May 17, 2019
dlabaj previously approved these changes May 17, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great job! Thanks @rebeccaalpert !

dlabaj dismissed redallen’s stale review May 17, 2019 18:47

Re requesting review

dlabaj requested a review from redallen May 17, 2019 18:47
tlabaj suggested changes May 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Jest Test are failing.

dlabaj previously approved these changes May 28, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj previously approved these changes May 29, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler previously approved these changes May 29, 2019
View reviewed changes
redallen suggested changes May 30, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really close, thanks for your work!

Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.test.js
@@ -1,6 +1,6 @@
import React from 'react';

redallen May 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Change the extension on this file to .tsx

Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.tsx
/** A callback for when the input value changes. */
onChange?: (value: string, event: React.FormEvent<HTMLInputElement>) => void;
/** Type that the input accepts. */
type?: 'text' | 'date' | 'datetime-local' | 'email' | 'month' | 'number' | 'password' | 'search' | 'tel' | 'time' | 'url';

redallen May 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To allow use of the enum, I believe you need to add | TextInputTypes

Comment thread packages/patternfly-4/react-core/src/components/TextInput/TextInput.tsx
const { className, type, value, onChange, isValid, isReadOnly, isRequired, isDisabled, ...props } = this.props;
return (
<input
{...props}

redallen May 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's spread the props at the end to be consistent across components.

tlabaj approved these changes Jun 5, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 1707236 into patternfly:master Jun 5, 2019
rebeccaalpert deleted the textinput-typescript branch June 6, 2019 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 left review comments
dlabaj dlabaj left review comments
+3 more reviewers
redallen redallen requested changes
jschuler jschuler approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert TextInput to TypeScript

9 participants

Back | FazBrowse Home | New Git URL