FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(EmptyState): Convert empty state to TypeScript by rebeccaalpert · Pull Request #1917 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(EmptyState): Convert empty state to TypeScript - #1917

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
rebeccaalpert:empty-typescript
May 17, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(EmptyState): Convert empty state to TypeScript#1917
dlabaj merged 2 commits into
patternfly:masterfrom
rebeccaalpert:empty-typescript

Conversation

rebeccaalpert commented May 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Refactored empty state to TypeScript.

Fixes #1991.

patternfly-build commented May 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1917-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1917 into master will decrease coverage by <.01%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
- Coverage   81.84%   81.84%   -0.01%     
==========================================
  Files         628      628              
  Lines        7112     7139      +27     
  Branches      236      243       +7     
==========================================
+ Hits         5821     5843      +22     
  Misses       1163     1163              
- Partials      128      133       +5
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.83% <89.13%> (+0.03%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...mponents/EmptyState/EmptyStateSecondaryActions.tsx 75% <75%> (ø)
...-core/src/components/EmptyState/EmptyStateBody.tsx 87.5% <87.5%> (ø)
...-core/src/components/EmptyState/EmptyStateIcon.tsx 92.3% <92.3%> (ø)
...eact-core/src/components/EmptyState/EmptyState.tsx 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883bea4...15e9fab. Read the comment docs.

nicolethoen commented May 8, 2019

Copy link
Copy Markdown
Contributor

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

rachael-phillips mentioned this pull request May 13, 2019
Closed
redallen suggested changes May 15, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateBody.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateBody.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateIcon.tsx
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateIcon.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyStateSecondaryActions.tsx Outdated

rebeccaalpert commented May 17, 2019

Copy link
Copy Markdown
Member Author

Added test/demo and addressed PR feedback.

dlabaj approved these changes May 17, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great. Thanks!

tlabaj approved these changes May 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen previously requested changes May 17, 2019
View reviewed changes
Comment thread ...rnfly-4/react-integration/demo-app-ts/src/components/demos/EmptyStateDemo/EmptyStateDemo.tsx
}
}

export default EmptyStateDemo;

redallen May 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove export default

dlabaj dismissed redallen’s stale review May 17, 2019 20:19

Rebecca updated with comments.

dlabaj merged commit 1fb9934 into patternfly:master May 17, 2019
rebeccaalpert deleted the empty-typescript branch May 28, 2019 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert Empty State to Typescript

7 participants

Back | FazBrowse Home | New Git URL