FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(BackgroundImage): fixed background image spacing issue by jessiehuff · Pull Request #1923 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(BackgroundImage): fixed background image spacing issue - #1923

Merged
redallen merged 12 commits into
patternfly:masterfrom
jessiehuff:feat/updateBackgroundImage
May 6, 2019
ConversationCommits (12)ChecksFiles changed
Merged

fix(BackgroundImage): fixed background image spacing issue #1923
redallen merged 12 commits into
patternfly:masterfrom
jessiehuff:feat/updateBackgroundImage

Conversation

jessiehuff commented May 3, 2019

Copy link
Copy Markdown
Contributor

Fixes #1922

patternfly-build commented May 3, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1923-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@86b7c42). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1923   +/-   ##
=========================================
  Coverage          ?   82.63%           
=========================================
  Files             ?      624           
  Lines             ?     6875           
  Branches          ?       93           
=========================================
  Hits              ?     5681           
  Misses            ?     1154           
  Partials          ?       40
Flag Coverage Δ
#patternfly3 84.89% <ø> (?)
#patternfly4 79.37% <ø> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
.../src/components/BackgroundImage/BackgroundImage.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b7c42...5cdc9c9. Read the comment docs.

jessiehuff requested review from dlabaj and mcoker May 3, 2019 18:46
mcoker approved these changes May 3, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks good, thanks!

tlabaj approved these changes May 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj added PF4 labels May 3, 2019
redallen approved these changes May 6, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

:)

redallen merged commit ce38bae into patternfly:master May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker approved these changes
dlabaj Awaiting requested review from dlabaj
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LoginPage has spacing issue

6 participants

Back | FazBrowse Home | New Git URL