fix(Checkbox): Set checked value correctly - #1929
Merged
tlabaj merged 1 commit intoMay 16, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://1929-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 82.63% 82.64% +0.01%
==========================================
Files 624 624
Lines 6875 6879 +4
Branches 93 94 +1
==========================================
+ Hits 5681 5685 +4
Misses 1154 1154
Partials 40 40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
tlabaj
reviewed
May 8, 2019
Copy link
Copy Markdown
Member
Author
|
Done 👍 |
Sorry, something went wrong.
dlabrecq
approved these changes
May 11, 2019
tlabaj
approved these changes
May 16, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
closes #1959
I first realized that the controlled Checkbox example is wrong: event.target.name is not set and so the state can be {check1: false, check2: false, '': false} or {check1: false, check2: false, '': true}.
After fixing it by adding the name attribute to the Checkbox components the first time I checked one of the boxes I got the following error/warning message:
Warning: A component is changing an uncontrolled input of type checkbox to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components in input (created by Checkbox) in div (created by Checkbox) in Checkbox (created by ControlledCheckbox) in ControlledCheckbox (created by ErrorBoundary) in ErrorBoundary (created by Context.Consumer)It looks like the expression isChecked || checked will return undefined if isChecked is false and so when checking the box that expression changed to true which causes the component to turn to be controlled.
//cc @dlabrecq
fixes https://github.com/project-koku/koku-ui/issues/841