FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(List): Convert list to TypeScript by rebeccaalpert · Pull Request #1946 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(List): Convert list to TypeScript - #1946

Merged
dlabaj merged 3 commits into
patternfly:masterfrom
rebeccaalpert:list-typescript
May 20, 2019
ConversationCommits (3)ChecksFiles changed
Merged

feat(List): Convert list to TypeScript#1946
dlabaj merged 3 commits into
patternfly:masterfrom
rebeccaalpert:list-typescript

Conversation

rebeccaalpert commented May 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Converted to TypeScript.

Fixes #1994.

patternfly-build commented May 7, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1946-pr-patternfly-react-patternfly.surge.sh

nicolethoen commented May 8, 2019

Copy link
Copy Markdown
Contributor

@rebeccaalpert can you also add integration tests for this component as outlined on this README?

dlabaj requested changes May 8, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also add integration tests for ListVariant, List, ListProps, ListItem, and ListItemProps.

Comment thread packages/patternfly-4/react-core/src/components/List/ListItem.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/List/__snapshots__/List.test.js.snap Outdated
Comment thread packages/patternfly-4/react-core/src/components/List/index.ts Outdated
rachael-phillips mentioned this pull request May 13, 2019
Closed
seanforyou23 reviewed May 15, 2019
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome work! Can we use git mv to rename the primary component files instead of deleting and recreating them? If we can do this, we'll retain the ability to trace the history of these modules going forward which is important for tracking down when certain changes were made, by who, and why. Looks like you've done this for may of the component files already, if we could give the same treatment for the others that would be great.

codecov-io commented May 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1946 into master will decrease coverage by 0.03%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
- Coverage   81.84%   81.81%   -0.04%     
==========================================
  Files         628      629       +1     
  Lines        7112     7116       +4     
  Branches      236      240       +4     
==========================================
+ Hits         5821     5822       +1     
  Misses       1163     1163              
- Partials      128      131       +3
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.73% <81.25%> (-0.07%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/LoginPage/LoginPage.tsx 63.63% <ø> (ø) ⬆️
...tternfly-4/react-core/src/components/List/index.ts 100% <100%> (ø)
...nfly-4/react-core/src/components/List/ListItem.tsx 50% <50%> (ø)
...tternfly-4/react-core/src/components/List/List.tsx 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883bea4...d5ca189. Read the comment docs.

rebeccaalpert commented May 16, 2019

Copy link
Copy Markdown
Member Author

Added demo and test. I also addressed @dlabaj's PR feedback. @seanforyou23, as noted on Slack, git mv doesn't seem to net a different outcome, so I'm leaving that as-is for now.

rebeccaalpert requested a review from tlabaj May 16, 2019 19:23
dlabaj self-assigned this May 17, 2019
tlabaj approved these changes May 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great Rebecca.

dlabaj merged commit ecb2702 into patternfly:master May 20, 2019
rebeccaalpert deleted the list-typescript branch May 28, 2019 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
seanforyou23 seanforyou23 left review comments
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert list to Typescript

8 participants

Back | FazBrowse Home | New Git URL