FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(OptionsMenu): Options Menu Component Typescript Conversion by nicolethoen · Pull Request #2002 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(OptionsMenu): Options Menu Component Typescript Conversion - #2002

Merged
redallen merged 16 commits into
patternfly:masterfrom
nicolethoen:options_menu_typescript_conversion
May 30, 2019
ConversationCommits (16)ChecksFiles changed
Merged

feat(OptionsMenu): Options Menu Component Typescript Conversion#2002
redallen merged 16 commits into
patternfly:masterfrom
nicolethoen:options_menu_typescript_conversion

Conversation

nicolethoen commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

#2024

Includes demo and integration tests

patternfly-build commented May 14, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2002-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2002 into master will decrease coverage by 0.35%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   81.09%   80.73%   -0.36%     
==========================================
  Files         643      642       -1     
  Lines        7706     7777      +71     
  Branches      451      504      +53     
==========================================
+ Hits         6249     6279      +30     
- Misses       1257     1258       +1     
- Partials      200      240      +40
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 76.25% <58.33%> (-0.64%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...mponents/OptionsMenu/OptionsMenuToggleWithText.tsx 36.36% <36.36%> (ø)
...e/src/components/OptionsMenu/OptionsMenuToggle.tsx 43.47% <43.47%> (ø)
...ore/src/components/OptionsMenu/OptionsMenuItem.tsx 52.38% <52.38%> (ø)
...rc/components/OptionsMenu/OptionsMenuItemGroup.tsx 57.14% <57.14%> (ø)
...rc/components/OptionsMenu/OptionsMenuSeparator.tsx 85.71% <85.71%> (ø)
...ct-core/src/components/OptionsMenu/OptionsMenu.tsx 85.71% <85.71%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c04803...0bfbbe2. Read the comment docs.

seanforyou23 reviewed May 15, 2019
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome work! Can we use git mv to rename the primary component files instead of deleting and recreating them? If we can do this, we'll retain the ability to trace the history of these modules going forward which is important for tracking down when certain changes were made, by who, and why. Looks like you've already done this for several of them.

nicolethoen force-pushed the options_menu_typescript_conversion branch 2 times, most recently from 87011e1 to 4d64cd6 Compare May 15, 2019 16:50
nicolethoen changed the title feat(OptionsMenu): Options Menu Component Typescript Conversion (WIP) feat(OptionsMenu): Options Menu Component Typescript Conversion May 15, 2019

nicolethoen commented May 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm noticing the OptionsMenuWithText component is having its properties listed twice in the documentation - and the second time they are printed, the descriptions and default values are missing. Does anyone know why that would be happening? @redallen @dgutride

nicolethoen mentioned this pull request May 16, 2019
Closed

rachael-phillips commented May 17, 2019

Copy link
Copy Markdown
Contributor

@dgutride @redallen were we able to address @nicolethoen 's comment above?

nicolethoen commented May 17, 2019

Copy link
Copy Markdown
Contributor Author

@dgutride @redallen were we able to address @nicolethoen 's comment above?

I think that quirk resolved itself. :)

dlabaj requested changes May 21, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few comments. Other than that looks good. Thanks @nicolethoen

Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.tsx
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItem.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItem.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItemGroup.tsx
dlabaj requested a review from tlabaj May 21, 2019 17:35
nicolethoen force-pushed the options_menu_typescript_conversion branch from f5ec6ca to 2453d71 Compare May 22, 2019 13:50
dlabaj previously approved these changes May 28, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm

nicolethoen force-pushed the options_menu_typescript_conversion branch from 2453d71 to f56383e Compare May 28, 2019 18:34
jschuler reviewed May 28, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.md Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.md Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.tsx
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItemGroup.tsx
nicolethoen force-pushed the options_menu_typescript_conversion branch from f56383e to fd9f04a Compare May 29, 2019 13:50
redallen suggested changes May 29, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really close, thank you!

Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.md
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.md
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.tsx
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItem.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItem.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItemGroup.tsx
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuItemGroup.tsx
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuToggle.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenuToggleWithText.tsx Outdated
nicolethoen force-pushed the options_menu_typescript_conversion branch from fd9f04a to 26130de Compare May 29, 2019 17:40
redallen approved these changes May 30, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, thanks!

redallen merged commit 402718b into patternfly:master May 30, 2019
nicolethoen deleted the options_menu_typescript_conversion branch February 8, 2023 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj left review comments
tlabaj Awaiting requested review from tlabaj
+3 more reviewers
seanforyou23 seanforyou23 left review comments
jschuler jschuler approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL