feat(Select): add typeahead keyboard navigation - #2013
Merged
redallen merged 4 commits intoJun 5, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://2013-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
==========================================
- Coverage 81.09% 80.48% -0.61%
==========================================
Files 643 642 -1
Lines 7706 7820 +114
Branches 451 509 +58
==========================================
+ Hits 6249 6294 +45
- Misses 1257 1286 +29
- Partials 200 240 +40
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
You have some merge conflicts now, but I like the interaction on the demo! |
Sorry, something went wrong.
kmcfaul
force-pushed
the
typeahead-keyboard
branch
from
c1b7d08 to
5ba262b
Compare
May 29, 2019 16:48
dlabaj
approved these changes
Jun 5, 2019
redallen
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Adds keyboard interaction to typeahead variants, other variants should remain unchanged.
Enter, with select closed, toggles open the menu.
Focus should remain on input.
Arrow up and down navigates the options with a focus styling.
Enter, with select opened, selects the highlighted item.
Refer to issue: #1842