FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Dropdown): handle on enter focusing when options are disabled by kmcfaul · Pull Request #2025 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Dropdown): handle on enter focusing when options are disabled - #2025

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
kmcfaul:dropdown-disabled-fix
May 17, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Dropdown): handle on enter focusing when options are disabled#2025
tlabaj merged 1 commit into
patternfly:masterfrom
kmcfaul:dropdown-disabled-fix

Conversation

kmcfaul commented May 16, 2019 •
edited by redallen
Loading

Copy link
Copy Markdown
Contributor

What: fix for handling when options are disabled. Focus should be on the first non-disabled item.

Refer to issue: Fixes #2017

kmcfaul added the PF4 label May 16, 2019

patternfly-build commented May 16, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2025-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 16, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2025 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2025      +/-   ##
==========================================
- Coverage   82.43%   82.41%   -0.03%     
==========================================
  Files         627      627              
  Lines        6951     6953       +2     
  Branches      119      119              
==========================================
  Hits         5730     5730              
- Misses       1162     1164       +2     
  Partials       59       59
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.88% <0%> (-0.06%) ⬇️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...react-core/src/components/Dropdown/DropdownMenu.js 55.26% <0%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64bc3a...4066af2. Read the comment docs.

redallen approved these changes May 17, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Dropdown/DropdownMenu.js
if (this.props.openedOnEnter) {
if (this.props.component === 'ul') this.refsCollection[0].focus();
const focusTarget =
this.refsCollection.filter(

redallen May 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the future, you can use .find() instead of .filter()[0]

dlabaj requested a review from tlabaj May 17, 2019 18:32
tlabaj approved these changes May 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 8903702 into patternfly:master May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PF4 Dropdown throws error if first DropdownItem is disabled with Tab key

5 participants

Back | FazBrowse Home | New Git URL