FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(docs): use frontmatter for what props to show in docs by redallen · Pull Request #2072 · patternfly/patternfly-react · GitHub

fix(docs): use frontmatter for what props to show in docs - #2072

Merged
dgutride merged 8 commits into
patternfly:masterfrom
redallen:docs/frontmatter-props
May 29, 2019
Merged

fix(docs): use frontmatter for what props to show in docs#2072
dgutride merged 8 commits into
patternfly:masterfrom
redallen:docs/frontmatter-props

Conversation

Copy link
Copy Markdown
Contributor

What: Fixes #2003

Additional issues:

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2072-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 23, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2072 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files         636      636           
  Lines        7560     7560           
  Branches      451      451           
=======================================
  Hits         6148     6148           
  Misses       1212     1212           
  Partials      200      200
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 77.2% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288da47...dcf78e1. Read the comment docs.

dgutride previously approved these changes May 24, 2019
redallen requested a review from jschuler May 24, 2019 13:13
dlabaj previously approved these changes May 28, 2019

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj commented May 28, 2019

Copy link
Copy Markdown
Contributor

@redallen Popover.md has a conflict.

redallen dismissed stale reviews from dlabaj and dgutride via dcf78e1 May 29, 2019 12:49
dgutride merged commit 20e6b12 into patternfly:master May 29, 2019
redallen deleted the docs/frontmatter-props branch May 29, 2019 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some components are missing prop documentation

6 participants


Back | FazBrowse Home | New Git URL