feat(backdrop): Convert backdrop to typescript - #2105
Merged
tlabaj merged 3 commits intoJun 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://2105-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
- Coverage 80.84% 80.82% -0.03%
==========================================
Files 651 652 +1
Lines 8260 8260
Branches 628 630 +2
==========================================
- Hits 6678 6676 -2
Misses 1282 1282
- Partials 300 302 +2
Continue to review full report at Codecov.
|
Sorry, something went wrong.
redallen
approved these changes
May 29, 2019
redallen
suggested changes
Jun 5, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Backdrop/Backdrop.tsx
Outdated
redallen
approved these changes
Jun 7, 2019
tlabaj
approved these changes
Jun 10, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2104