FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Charts): Fix themes for bar chart default colors by TheRealJon · Pull Request #2112 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Charts): Fix themes for bar chart default colors - #2112

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
TheRealJon:issue-2111
Jun 3, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Charts): Fix themes for bar chart default colors#2112
tlabaj merged 1 commit into
patternfly:masterfrom
TheRealJon:issue-2111

Conversation

TheRealJon commented May 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2111

What:
Add default bar fill color to all themes so that standard (ungrouped) bar charts will have an appropriate fill color.

TheRealJon requested a review from dlabrecq May 29, 2019 20:06

patternfly-build commented May 29, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2112-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2112 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2112   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         648      648           
  Lines        7869     7869           
  Branches      505      505           
=======================================
  Hits         6370     6370           
  Misses       1259     1259           
  Partials      240      240
Flag Coverage Δ
#patternfly3 85.21% <ø> (ø) ⬆️
#patternfly4 76.28% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ts/src/components/ChartTheme/themes/theme-color.js 100% <ø> (ø) ⬆️
...nents/ChartTheme/themes/light/theme-color-multi.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c81d2f...4701224. Read the comment docs.

TheRealJon requested a review from dlabrecq May 30, 2019 15:52
dlabrecq previously approved these changes May 30, 2019
View reviewed changes
tlabaj previously approved these changes May 30, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

TheRealJon commented May 30, 2019

Copy link
Copy Markdown
Contributor Author

I have no idea why snapshots are failing. I've done everything I know to do to make sure the snapshots are up to date, and they should be, but for some reason, unit tests are still failing. @dlabrecq Any ideas?

dlabrecq commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I recall encountering a similar error with stale packages, but running yarn install; yarn test -u seemed to clear it up.

TheRealJon commented May 31, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Tried that. Tried a clean yarn install at the root level, clean build of all packages, and full unit test run with -u flag, got no new snapshot updates.

TheRealJon dismissed stale reviews from tlabaj and dlabrecq via 4701224 May 31, 2019 17:47
TheRealJon requested review from dlabrecq and tlabaj and removed request for dlabrecq May 31, 2019 17:47

TheRealJon commented May 31, 2019

Copy link
Copy Markdown
Contributor Author

@dlabrecq @tlabaj Could I get approvals again? I had to push updated test snapshots to get CI to pass.

dlabrecq mentioned this pull request Jun 2, 2019
Merged

TheRealJon commented Jun 3, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj Could you approve again? Looks like CI is passing now. Should be good to merge.

tlabaj approved these changes Jun 3, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 7b290ab into patternfly:master Jun 3, 2019
TheRealJon deleted the issue-2111 branch June 26, 2019 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dlabrecq dlabrecq approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chart theme does not apply base color to bar chart

5 participants

Back | FazBrowse Home | New Git URL