fix(PF4 Table): Export RowWrapper implementation - #2118
Merged
redallen merged 1 commit intoJun 5, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://2118-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #2118 +/- ##
=======================================
Coverage 80.74% 80.74%
=======================================
Files 642 642
Lines 7781 7781
Branches 504 504
=======================================
Hits 6283 6283
Misses 1258 1258
Partials 240 240
Continue to review full report at Codecov.
|
Sorry, something went wrong.
redallen
approved these changes
May 30, 2019
priley86
approved these changes
May 31, 2019
priley86
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I am no longer using Row/Body/Cell Wrappers. No issues w/ this.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
When using react table in typescript project there is no way how to import RowWrapper implementation and copy pasting parts of it is bad. So this PR fixes this problem by exporting RowWrapperProps as interface and RowWrapper as implementation.
Additional issues:
There might be problems because we are changing interface to implementation, but this is not that greatly used interface so it should be fine. @suomiy, @priley86 are you using this interface somewhere?
Fixes: #2109