FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Modal): Allow custom header and footer by jeff-phillips-18 · Pull Request #2120 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Modal): Allow custom header and footer - #2120

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
jeff-phillips-18:modal-header
Jul 30, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(Modal): Allow custom header and footer#2120
dlabaj merged 2 commits into
patternfly:masterfrom
jeff-phillips-18:modal-header

Conversation

jeff-phillips-18 commented May 30, 2019

Copy link
Copy Markdown
Member

What:
Allows for custom header and/or footer in Modal component

Fixes #1545

codecov-io commented May 31, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@cdac10a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2120   +/-   ##
=========================================
  Coverage          ?   80.75%           
=========================================
  Files             ?      642           
  Lines             ?     7791           
  Branches          ?      509           
=========================================
  Hits              ?     6292           
  Misses            ?     1259           
  Partials          ?      240
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 76.31% <100%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...-core/src/components/Modal/ModalBoxCloseButton.tsx 75% <ø> (ø)
...ernfly-4/react-core/src/components/Modal/Modal.tsx 88.23% <ø> (ø)
...4/react-core/src/components/Modal/ModalContent.tsx 72.97% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdac10a...e511d47. Read the comment docs.

patternfly-build commented May 31, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2120-pr-patternfly-react-patternfly.surge.sh

jeff-phillips-18 changed the title feat(Modal): Allow custom header and footer WIP: feat(Modal): Allow custom header and footer Jun 3, 2019
redallen previously approved these changes Jul 2, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix conflicts and this is good!

Hyperkid123 commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

@jeff-phillips-18 can you fix the conflicts please? We could really use this one. Or if you want I cant take this over.

jeff-phillips-18 changed the title WIP: feat(Modal): Allow custom header and footer feat(Modal): Allow custom header and footer Jul 29, 2019

jeff-phillips-18 commented Jul 29, 2019

Copy link
Copy Markdown
Member Author

Rebased, removed WIP

patternfly-build commented Jul 29, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2120.surge.sh

Hyperkid123 commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

@jeff-phillips-18 is it possible to include the close button to the modal Header? That would let us to customize the header completely.

Right now the button is the only thing that we cannot do anything about.

jeff-phillips-18 commented Jul 30, 2019

Copy link
Copy Markdown
Member Author

@Hyperkid123 Added the showClose prop, defaulted to true. Set to false to hide the close button.

redallen approved these changes Jul 30, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj approved these changes Jul 30, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 9d2f157 into patternfly:master Jul 30, 2019

patternfly-build commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.79.0
  • @patternfly/react-docs@4.9.10
  • @patternfly/react-inline-edit-extension@2.9.56
  • demo-app-ts@2.14.0
  • @patternfly/react-integration@2.14.0
  • @patternfly/react-table@2.15.4
  • @patternfly/react-topology@2.7.5
  • @patternfly/react-virtualized-extension@1.1.89

Thanks for your contribution! 🎉

jeff-phillips-18 deleted the modal-header branch May 12, 2022 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modal - add render prop to allow for custom title content

7 participants

Back | FazBrowse Home | New Git URL