FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(ContextSelector): Convert context selector to typescript by jessiehuff · Pull Request #2147 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(ContextSelector): Convert context selector to typescript - #2147

Merged
dlabaj merged 7 commits into
patternfly:masterfrom
jessiehuff:feat/contextSelectorTS
Jun 17, 2019
ConversationCommits (7)ChecksFiles changed
Merged

feat(ContextSelector): Convert context selector to typescript#2147
dlabaj merged 7 commits into
patternfly:masterfrom
jessiehuff:feat/contextSelectorTS

Conversation

jessiehuff commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Fixes #2146

patternfly-build commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2147-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2147 into master will increase coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master   #2147      +/-   ##
=========================================
+ Coverage   80.59%   80.6%   +0.01%     
=========================================
  Files         666     666              
  Lines        8440    8523      +83     
  Branches      719     737      +18     
=========================================
+ Hits         6802    6870      +68     
- Misses       1280    1288       +8     
- Partials      358     365       +7
Flag Coverage Δ
#patternfly3 85.23% <ø> (ø) ⬆️
#patternfly4 76.26% <75%> (+0.1%) ⬆️
#patternflymisc 95.79% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...nents/ContextSelector/contextSelectorConstants.tsx 100% <100%> (ø)
...mponents/ContextSelector/ContextSelectorToggle.tsx 56.89% <50%> (ø)
...src/components/ContextSelector/ContextSelector.tsx 85.41% <69.23%> (ø)
...components/ContextSelector/ContextSelectorItem.tsx 85% <85.71%> (ø)
...onents/ContextSelector/ContextSelectorMenuList.tsx 94.73% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47558f3...354850c. Read the comment docs.

redallen previously approved these changes Jun 7, 2019
View reviewed changes
dlabaj reviewed Jun 10, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few comments.

Comment thread packages/patternfly-4/react-core/src/components/ContextSelector/ContextSelector.tsx Outdated
onEnterPressed = (event: any) => {
if (event.charCode === KEY_CODES.ENTER) {
this.props.onSearchButtonClick();
this.props.onSearchButtonClick(null);

dlabaj Jun 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You shouldn't have to pass null here...

jessiehuff Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was running into a typescript error about it which is why I added it, but I can make the event argument optional instead so that null isn't passed.

Comment thread packages/patternfly-4/react-core/src/components/ContextSelector/ContextSelectorItem.tsx
Comment thread packages/patternfly-4/react-core/src/components/ContextSelector/ContextSelectorMenuList.tsx
tlabaj approved these changes Jun 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

LGTM

dlabaj merged commit 9a4f484 into patternfly:master Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert ContextSelector to Typescript

6 participants

Back | FazBrowse Home | New Git URL