FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Topology): Add @patternfly/react-topology package by jeff-phillips-18 · Pull Request #2170 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Topology): Add @patternfly/react-topology package - #2170

Merged
redallen merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:topology-package
Jun 11, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(Topology): Add @patternfly/react-topology package#2170
redallen merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:topology-package

Conversation

jeff-phillips-18 commented Jun 5, 2019

Copy link
Copy Markdown
Member

What:
Add initial @patternfly/react-topology package containing the TopologyView and TopologyControlBar components.

FYI: @christianvogt

jeff-phillips-18 force-pushed the topology-package branch 2 times, most recently from 076e232 to 363d793 Compare June 6, 2019 13:32

codecov-io commented Jun 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2170 into master will increase coverage by 0.09%.
The diff coverage is 55.76%.

@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
+ Coverage   80.44%   80.53%   +0.09%     
==========================================
  Files         662      656       -6     
  Lines        8349     8364      +15     
  Branches      643      687      +44     
==========================================
+ Hits         6716     6736      +20     
+ Misses       1331     1282      -49     
- Partials      302      346      +44
Flag Coverage Δ
#patternfly3 85.22% <ø> (-0.02%) ⬇️
#patternfly4 75.97% <55.76%> (+0.2%) ⬆️
#patternflymisc 95.68% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
...c/components/TopologyView/css/topology-view-css.ts 100% <100%> (ø)
...eact-topology/src/components/TopologyView/index.ts 100% <100%> (ø)
.../TopologyControlBar/css/topology-controlbar-css.ts 100% <100%> (ø)
...mponents/TopologyControlBar/TopologyControlBar.tsx 46.42% <46.42%> (ø)
...ology/src/components/TopologyView/TopologyView.tsx 93.33% <93.33%> (ø)
...ternfly-4/react-table/src/components/Table/Body.js 87.5% <0%> (-0.74%) ⬇️
test.env.js 100% <0%> (ø) ⬆️
...ct-core/src/components/Pagination/OptionsToggle.js 83.33% <0%> (ø) ⬆️
...y-3/patternfly-react/src/components/Label/Label.js 100% <0%> (ø) ⬆️
...ly-3/patternfly-react/src/components/Cards/Card.js 100% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8bf5f5...7f1ca55. Read the comment docs.

patternfly-build commented Jun 6, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2170-pr-patternfly-react-patternfly.surge.sh

jeff-phillips-18 force-pushed the topology-package branch 2 times, most recently from 58a8a12 to c6589e6 Compare June 6, 2019 20:13
redallen previously approved these changes Jun 7, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I love this package, thanks!

Comment thread packages/patternfly-4/react-topology/build/snapshot-serializer.js Outdated
@@ -0,0 +1,8 @@
const fs = require('fs');

redallen Jun 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't need this file since jest uses the one from react-core.

Comment thread packages/patternfly-4/react-topology/scripts/copyTS.js
@@ -0,0 +1,15 @@
const path = require('path');

redallen Jun 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With no .d.ts files in this project, we don't need this script.

jeff-phillips-18 commented Jun 10, 2019

Copy link
Copy Markdown
Member Author

Updated per comments, rebased.

dgutride reviewed Jun 11, 2019
View reviewed changes

dgutride left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it looks pretty good - one or two minor build adjustments on my end

Comment thread packages/patternfly-4/react-docs/gatsby-node.js Outdated
'@patternfly/react-styles': path.resolve(__dirname, '../react-styles'),
'@patternfly/react-table': path.resolve(__dirname, '../react-table'),
'@patternfly/react-tokens': path.resolve(__dirname, '../react-tokens'),
'@patternfly/react-topology': path.resolve(__dirname, '../react-topology/dist/esm'),

dgutride Jun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why does this need the module path specifically?

jeff-phillips-18 Jun 11, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was having a strange build issue w/o the path. That seems to be resolved now so I believe I can remove it.

Comment thread packages/patternfly-4/react-charts/package.json Outdated
"build:babel:cjs": "cross-env BABEL_ENV=production:cjs babel src --out-dir dist/js --extensions '.js,.ts,.tsx' -q",
"build:babel:esm": "cross-env BABEL_ENV=production:esm babel src --out-dir dist/esm --extensions '.js,.ts,.tsx' -q",
"build:babel:umd": "cross-env BABEL_ENV=production:umd babel dist/esm --out-dir dist/umd --plugins transform-es2015-modules-umd --extensions '.js,.ts,.tsx' -q",
"build:babel:cjs": "babel src --out-dir dist/js --extensions '.js,.ts,.tsx' -q",

dgutride Jun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This file shouldn't be included here - please revert

Comment thread packages/patternfly-4/react-topology/.babelrc.js Outdated
@@ -0,0 +1,5 @@
const coreConfig = require('../react-core/.babelrc.js');

dgutride Jun 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This location changed to the root of patternfly-4 now

jeff-phillips-18 force-pushed the topology-package branch 3 times, most recently from 572f15e to a39dd88 Compare June 11, 2019 14:54
redallen approved these changes Jun 11, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again!

redallen merged commit 58eb9cc into patternfly:master Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
dgutride dgutride approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL